Small hash-related improvements #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fviernau
requested changes
Feb 2, 2024
| @@ -609,7 +610,7 @@ class Pub( | |||
|
|
|||
| RemoteArtifact( | |||
| url = "$hostUrl/packages/$rawName/versions/$version.tar.gz", | |||
| hash = Hash.create(sha256) | |||
| hash = Hash(sha256, HashAlgorithm.SHA256) | |||
There was a problem hiding this comment.
After my related PR is merged, using constructor instead of create() would by-pass turning the value lowercase. At least it was my intention to make create() ensure the value passed to the constructor is lowercase.
Maybe we can discuss it here in one place: #8214 (comment)
There was a problem hiding this comment.
So, from the linked discussion, I believe this could now just be changed to call the create() function, passing again, but pass the algorithm, right?
fviernau
changed the title
sschuberth
force-pushed
the
sha-companions
branch
from
fc7d7c2 to
427f199
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
This avoids the guessing logic depending on the value's length to kick in. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
sha-companions
branch
from
427f199 to
bbfde76
Compare
fviernau
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.