Support namespace-level package curations from ort-config
#8204
Conversation
sschuberth
force-pushed
the
namespace-ort-curations
branch
from
5991983 to
e772ef3
Compare
| @@ -88,7 +88,7 @@ class DirPackageConfigurationProvider( | |||
| "The path '$it' does not exist." | |||
| } | |||
|
|
|||
| if (it.isDirectory) FileFormat.findFilesWithKnownExtensions(it) else listOf(it) | |||
| if (it.isDirectory) FileFormat.findFilesWithKnownExtensions(it).sorted() else listOf(it) | |||
There was a problem hiding this comment.
commit-msg: Should the last sentence indicate, that it is specific to the OrtConfig...Provider?
There was a problem hiding this comment.
No. While _.yml are conventional with the ort-config provider, they could be used with a file provider as well. Phrased differently, when pointing a file provider to the local checkout of the ort-config provider, you should get the same curations in the same order.
| @@ -103,7 +103,7 @@ class FilePackageCurationProvider( | |||
| "The path '$it' does not exist." | |||
| } | |||
|
|
|||
| if (it.isDirectory) FileFormat.findFilesWithKnownExtensions(it) else listOf(it) | |||
| if (it.isDirectory) FileFormat.findFilesWithKnownExtensions(it).sorted() else listOf(it) | |||
There was a problem hiding this comment.
We had this topic of ordering vs. added complexity already before, but I do not recall the details.
My preference still is to not assume any ordering but instead require each curation to be correct on its own.
Because for correct curations, the order does not matter. Anyhow, it'd be interested to hear further opinions on this. Also how much of an edge case this is. IMO it'd would be that problematic to not use namespace curations
if the curation does not apply to all packages in the namespace.
There was a problem hiding this comment.
If it helps to get this merged more quickly, I'm happy to drop the last commit.
There was a problem hiding this comment.
I'm happy to drop the last commit.
Done.
Signed-off-by: Sebastian Schuberth <[email protected]>
This is required to support curations like the one added in [1]. [1]: oss-review-toolkit/ort-config#165 Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
namespace-ort-curations
branch
2 times, most recently
from
d0e2367 to
42cb229
Compare
Please have a look at the individual commit messages for the details.