Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm: Forward warnings from npm just as Hint, not as Warning #8182

Merged
merged 1 commit into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7772,20 +7772,20 @@ issues:
source: "NPM"
message: "deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade\
\ to chokidar 3 with 15x less dependencies."
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: core-js@<3.3 is no longer maintained and not\
\ recommended for usage due to the number of issues. Because of the V8 engine\
\ whims, feature detection in old core-js versions could cause a slowdown up to\
\ 100x even if nothing is polyfilled. Please, upgrade your dependencies to the\
\ actual version of core-js."
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated"
severity: "WARNING"
severity: "HINT"
Original file line number Diff line number Diff line change
Expand Up @@ -1156,9 +1156,9 @@ issues:
message: "The npm-shrinkwrap.json file was created with an old version of npm, so\
\ supplemental metadata must be fetched from the registry. This is a one-time\
\ fix-up, please be patient..."
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: CoffeeScript on NPM has moved to \"coffeescript\"\
\ (no hyphen)"
severity: "WARNING"
severity: "HINT"
Original file line number Diff line number Diff line change
Expand Up @@ -1192,9 +1192,9 @@ issues:
message: "The <REPLACE_LOCKFILE_NAME> file was created with an old version of npm, so\
\ supplemental metadata must be fetched from the registry. This is a one-time\
\ fix-up, please be patient..."
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: CoffeeScript on NPM has moved to \"coffeescript\"\
\ (no hyphen)"
severity: "WARNING"
severity: "HINT"
Original file line number Diff line number Diff line change
Expand Up @@ -5152,54 +5152,54 @@ issues:
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Removed event-stream from gulp-header"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please upgrade to v0.1.7"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please upgrade to v1.0.1"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please upgrade to v0.1.5"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please upgrade to v1.0.1"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Legacy versions of mkdirp are no longer supported.\
\ Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises\
\ in 1.x.)"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated"
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "skipping integrity check for git dependency ssh://[email protected]/jonschlinkert/gulp-format-md.git "
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "skipping integrity check for git dependency ssh://[email protected]/mochajs/mocha.git "
severity: "WARNING"
severity: "HINT"
- timestamp: "1970-01-01T00:00:00Z"
source: "NPM"
message: "skipping integrity check for git dependency ssh://[email protected]/tinydesk/angular-tileview.git "
severity: "WARNING"
severity: "HINT"
2 changes: 1 addition & 1 deletion plugins/package-managers/node/src/main/kotlin/Npm.kt
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ open class Npm(
val issues = mutableListOf<Issue>()

lines.groupLines("npm WARN ").mapTo(issues) {
Issue(source = managerName, message = it, severity = Severity.WARNING)
Issue(source = managerName, message = it, severity = Severity.HINT)
}

lines.groupLines("npm ERR! ").mapTo(issues) {
Expand Down
Loading