test(compare-command): Add a functional test for the text diff method #7950
Conversation
Signed-off-by: Sebastian Schuberth <[email protected]>
|
|
||
| class CompareCommandFunTest : WordSpec({ | ||
| "The text diff method" should { | ||
| "ignore time and environment differences in an analyzer result" { |
There was a problem hiding this comment.
Looking at what this tests covers vs. the test assets, I believe the assets contain a lot of unneeded stuff.
I believe it'd be better if the test only had one result hard-coded, then it should make a copy with environment modified and then assert the diff is empty.
Doing so could re-use an ORT file coded in Kotlin we already have, maybe.
There was a problem hiding this comment.
Hmm, not sure about this. I deliberately created real-life analyzer results, once from a Jenkins run on Linux, once from a manual run on Windows, to ensure the command works for these, instead of coming up with some artificial results that I'm patching up, with having in mind how the implementations works.
There was a problem hiding this comment.
So, would you be ok with sticking to the current approach @fviernau?
There was a problem hiding this comment.
Not really convinced, but the maybe unnecessary maintainance cost I tried to avoid are isolated and limited. So, ok let's make this compromise.
No description provided.