Plugin cleanups #7928
Merged
Plugin cleanups #7928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
requested review from
MarcelBochtler,
oheger-bosch and
a team
as code owners
fviernau
reviewed
Nov 24, 2023
| @@ -21,13 +21,21 @@ package org.ossreviewtoolkit.advisor | |||
|
|
|||
| import java.util.ServiceLoader | |||
|
|
|||
| import org.ossreviewtoolkit.utils.common.Plugin | |||
There was a problem hiding this comment.
commit-msg: "property in the was not" Something is wrong here, guess "in the" can be dropped.
generall-> generally
fviernau
approved these changes
Nov 24, 2023
…ions For some plugin types, the conventional `ALL` property was not defined in the actual plugin implementation, but in a class managing the plugin implementations. Resolve this inconsistency by generally defining the `ALL` properties in the belonging plugin implementation to prepare for an upcoming change that inspects plugin implementations. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
plugin-cleanups
branch
from
750e4e4 to
87ae991
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7928 +/- ##
=========================================
Coverage 66.99% 66.99%
Complexity 2041 2041
=========================================
Files 356 356
Lines 17103 17103
Branches 2443 2443
=========================================
Hits 11459 11459
Misses 4623 4623
Partials 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.