reporter: Prepare ReportTabelModelMapper for some clean-ups
#7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7927 +/- ##
=========================================
Coverage 66.96% 66.96%
Complexity 2041 2041
=========================================
Files 356 356
Lines 17084 17084
Branches 2443 2443
=========================================
Hits 11440 11440
Misses 4623 4623
Partials 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Prepare for reducing its visibility. Signed-off-by: Frank Viernau <[email protected]>
Consider it as an implementation detail of static HTML reporter. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
report-table-model-mapper-improvements
branch
from
3a00866 to
693d68a
Compare
Enable splitting up this function in a following change without the need to pass around too many parameters. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
report-table-model-mapper-improvements
branch
from
693d68a to
d5974ff
Compare
sschuberth
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the model internal and turn it to a class, to simplify cleaning up the code in a following PR.