Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helper-cli): Extend path exclude generator by a couple of patterns #7924

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

tsteenbe
Copy link
Member

Add patterns for common CI configuration, build or test files and dirs.

@tsteenbe tsteenbe requested a review from a team as a code owner November 23, 2023 12:43
@tsteenbe tsteenbe force-pushed the path-exclude-gen-updates branch from 051388b to 7160370 Compare November 23, 2023 12:51
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62a3bc5) 66.96% compared to head (ffc8a59) 66.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7924      +/-   ##
============================================
+ Coverage     66.96%   66.99%   +0.03%     
  Complexity     2041     2041              
============================================
  Files           356      356              
  Lines         17084    17103      +19     
  Branches       2443     2443              
============================================
+ Hits          11440    11459      +19     
  Misses         4623     4623              
  Partials       1021     1021              
Flag Coverage Δ
funTest-non-docker 34.35% <0.00%> (-0.12%) ⬇️
test 36.19% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsteenbe tsteenbe force-pushed the path-exclude-gen-updates branch from 7160370 to bce9d76 Compare November 23, 2023 14:13
@fviernau fviernau force-pushed the path-exclude-gen-updates branch from bce9d76 to 743a929 Compare November 23, 2023 20:26
@fviernau fviernau enabled auto-merge (rebase) November 23, 2023 20:27
@sschuberth
Copy link
Member

Commitlint cannot cope with multiple signed-off footers, unfortunately (same with co-authored-by footers). The pragmatic solution is to simply remove the signoff for the non-author, and eventually use the other user as the committer.

@fviernau
Copy link
Member

Commitlint cannot cope with multiple signed-off footers, unfortunately (same with co-authored-by footers). The pragmatic solution is to simply remove the signoff for the non-author, and eventually use the other user as the committer.

Ok if we just merge regardless of this failing check ?

@sschuberth
Copy link
Member

Ok if we just merge regardless of this failing check ?

I'm not sure if this will result in problems with future PRs... maybe Commitlint looks at all the history instead of just the commits introduced in a PR. So I'd prefer to reword the commit messages, like I also did here.

Add patterns for common CI configuration, build or test files and dirs.

Signed-off-by: Thomas Steenbergen <[email protected]>
@fviernau fviernau force-pushed the path-exclude-gen-updates branch from 743a929 to ffc8a59 Compare November 24, 2023 09:17
@fviernau fviernau merged commit 2107657 into main Nov 24, 2023
22 checks passed
@fviernau fviernau deleted the path-exclude-gen-updates branch November 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants