Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Extract .NET version to a variable #7865

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

fviernau
Copy link
Member

See individual commits.

@fviernau fviernau requested a review from a team as a code owner November 15, 2023 14:15
@fviernau fviernau enabled auto-merge (rebase) November 15, 2023 14:15
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (448a8bb) 67.06% compared to head (adb0b3d) 67.06%.

❗ Current head adb0b3d differs from pull request most recent head 5e0d7f3. Consider uploading reports for the commit 5e0d7f3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7865   +/-   ##
=========================================
  Coverage     67.06%   67.06%           
  Complexity     2041     2041           
=========================================
  Files           356      356           
  Lines         17045    17045           
  Branches       2438     2438           
=========================================
  Hits          11431    11431           
  Misses         4594     4594           
  Partials       1020     1020           
Flag Coverage Δ
funTest-non-docker 34.95% <ø> (+0.44%) ⬆️
test 36.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau added the on hold Pull requests that cannot currently be merged label Nov 15, 2023
@fviernau fviernau marked this pull request as draft November 15, 2023 14:50
auto-merge was automatically disabled November 15, 2023 14:50

Pull request was converted to draft

Align with `Dockerfile`.

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau force-pushed the docker-upgrade-dot-net branch from adb0b3d to 5e0d7f3 Compare November 16, 2023 08:47
@fviernau
Copy link
Member Author

fviernau commented Nov 16, 2023

I've tried upgrading to 8.0, but it seems that in order to analyze our test projects, .NET version 6.0 has to be installed.
E.g. with only 8.0, it fails with No instances of MSBuild could be detected.. So, I've dropped the upgrade commit.

@fviernau fviernau changed the title docker: Upgrade .NET to the latest version chore(docker): Extract .NET version to a variable Nov 16, 2023
@fviernau fviernau marked this pull request as ready for review November 16, 2023 08:49
@fviernau fviernau enabled auto-merge (rebase) November 16, 2023 08:49
@fviernau fviernau merged commit 0557aeb into main Nov 16, 2023
20 checks passed
@fviernau fviernau deleted the docker-upgrade-dot-net branch November 16, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Pull requests that cannot currently be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants