feat(docker): Rename images to new defaults #7801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
3 times, most recently
from
10702f7 to
2d1e251
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7801 +/- ##
=========================================
Coverage 67.24% 67.24%
Complexity 2044 2044
=========================================
Files 356 356
Lines 17057 17057
Branches 2440 2440
=========================================
Hits 11470 11470
Misses 4568 4568
Partials 1019 1019
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
5 times, most recently
from
35b1114 to
6f50f00
Compare
fviernau
reviewed
Nov 2, 2023
sschuberth
requested changes
Nov 2, 2023
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
3 times, most recently
from
0a33817 to
8722b15
Compare
sschuberth
previously requested changes
Nov 2, 2023
There was a problem hiding this comment.
Additionally the language component images now have named version with a hash to enable checking if contents of an image has changed without changing core language.
I propose to do this change in a preceding commit as it's not really on the topic of just renaming the Docker images.
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
3 times, most recently
from
2361b02 to
85002d7
Compare
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
3 times, most recently
from
2bbb467 to
5a2fd32
Compare
Is mention before, the change and fix are coupled, no reason to do two separate entries. |
tsteenbe
previously approved these changes
Nov 7, 2023
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
from
5a2fd32 to
af5028b
Compare
tsteenbe
previously approved these changes
Nov 8, 2023
heliocastro
dismissed
sschuberth’s stale review
This was answered and fixed on latest push
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
3 times, most recently
from
32cb536 to
20d65fd
Compare
fviernau
previously requested changes
Nov 9, 2023
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
2 times, most recently
from
afaec77 to
b01e2de
Compare
heliocastro
force-pushed
the
heliocastro/docker_fix
branch
from
b01e2de to
818840b
Compare
tsteenbe
approved these changes
Nov 9, 2023
In order to assemble the ORT docker image(s), the GitHub action first builds the component images and then the main images using the previously built component images. Each component image build is skipped (for efficiency) if the image with the needed tag already exists. As tag, the version of the tooling of the particular ecosystem is used, e.g. ghcr.io/oss-review-toolkit/python:3.11.5. Using only the main tooling version as cache key is problematic, because it leads to accidentally skipping of component image builds. This may happen when any of the BUILD ARGS has changed. Fix this by including a hash of the build args into the image tags. Signed-off-by: Helio Chissini de Castro <[email protected]>
The name changing allows to move the extended separated bits on previous adoption to a unified file. Now the new run target is based on previous extended image, and the original run target is now called minimal. Signed-off-by: Helio Chissini de Castro <[email protected]>
Change the build scripts to new minimal / ort images. Naming had a slightly change from components as add to a subdomain (ort/component) to a direct component naming, making equal to upstream naming. The explicit call to Dockerfile file name is not needed anymore, as only a single Dockerfile exists after name changing. Signed-off-by: Helio Chissini de Castro <[email protected]>
Custom image now is named with dash to match Dockerfile-legacy naming. Signed-off-by: Helio Chissini de Castro <[email protected]>
Rename Docker image 'ort' to 'ort-minimal' and 'ort-extended' to 'ort' as agreed in community vote to make it easier for new users to understand difference between ORT Docker images. Signed-off-by: Helio Chissini de Castro <[email protected]>
tsteenbe
force-pushed
the
heliocastro/docker_fix
branch
from
818840b to
54fe55f
Compare
tsteenbe
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Docker image 'ort' to 'ort-minimal' and 'ort-extended' to 'ort' as agreed in community vote
to make it easier for new users to understand difference between ORT Docker images.
Additionally the language component images now have named version with a hash to enable checking if contents
of an image has changed without changing core language.
Closes: #7798