build: Include platform projects when running from Gradle or the IDE #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Gradle 8.4 `dependencyScope` [1] to extend the `runtimeClasspath` with the `pluginClasspath`. This improves the solution from 1708ac3 by supporting to run ORT from Gradle or the IDE with platform projects / plugins in the classpath, but still do not publish them as part of the "dependencyManagement" in the POM. See [2] for context. [1]: https://docs.gradle.org/8.4/release-notes.html#easier-to-create-role-focused-configurations [2]: gradle/gradle#10861 (comment) Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7728 +/- ##
=========================================
Coverage 67.80% 67.80%
- Complexity 2045 2049 +4
=========================================
Files 352 352
Lines 16827 16853 +26
Branches 2379 2396 +17
=========================================
+ Hits 11410 11428 +18
- Misses 4427 4433 +6
- Partials 990 992 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Merging as urgently needed by third-party ORT development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a Gradle 8.4
dependencyScope1 to extend theruntimeClasspathwith thepluginClasspath. This improves the solution from 1708ac3 by supporting to run ORT from Gradle or the IDE with platform projects / plugins in the classpath, but still do not publish them as part of the "dependencyManagement" in the POM. See 2 for context.