Resolve plugin config vs classpath exceptions #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schuberth <[email protected]>
Previously, if a provider plugin was enabled in ORT's configuration but was unavailable in the classpath, the `ALL` map lookup threw a `NoSuchElementException` resulting in ORT to crash. Avoid that by logging this case as an error instead, but continuing to run. The ORT result file will properly reflect only the used provider plugins. Signed-off-by: Sebastian Schuberth <[email protected]>
In exchange, use the longer but more readable `factory` lambda parameter name. Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7723 +/- ##
=========================================
Coverage 67.81% 67.81%
Complexity 2045 2045
=========================================
Files 352 352
Lines 16829 16829
Branches 2380 2380
=========================================
Hits 11412 11412
Misses 4427 4427
Partials 990 990
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
oheger-bosch
approved these changes
Oct 20, 2023
AFAICT, other plugins do not get implicitly created by coming across their configuration, but by filtering enabled ones from those in the classpath. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.