GoMod: Minor follow-up fixes #7722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7722 +/- ##
============================================
- Coverage 67.81% 67.74% -0.08%
Complexity 2045 2045
============================================
Files 352 352
Lines 16829 16842 +13
Branches 2380 2385 +5
============================================
- Hits 11412 11409 -3
- Misses 4427 4443 +16
Partials 990 990
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
Oct 20, 2023
| @@ -98,7 +98,7 @@ class GoModFunTest : StringSpec({ | |||
| "Project dependencies with a (relative) local module dependency are detected correctly" { | |||
| val definitionFileApp = testDir.resolve("gomod-submodules/app/go.mod") | |||
| val definitionFileUtils = testDir.resolve("gomod-submodules/utils/go.mod") | |||
| val expectedResultFile = testDir.resolve("gomod-submodules-embed-expected-output.yml") | |||
| val expectedResultFile = testDir.resolve("gomod-submodules-expected-output.yml") | |||
There was a problem hiding this comment.
Commit message: Please explain why "embed" is wrong as part of the name.
The name was a copy / paste mistake from another test which tests handling of dangling references in embed directives. However, this test is not related to embed directives. Signed-off-by: Frank Viernau <[email protected]>
The reason why a `Map` is used is for better performance in the caller logic. So, creating that map better fits into the caller. The function now also aligns better with its KDoc. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
This is a fix-up for 1886e39. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
gomod-minor-clean-ups
branch
from
f6ed7c4 to
e491473
Compare
sschuberth
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.