Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(providers): Turn config classes into data classes #7639

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

sschuberth
Copy link
Member

These are property-only classes which are a perfect fit for data classes.

These are property-only classes which are a perfect fit for data
classes.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner October 5, 2023 12:49
@sschuberth sschuberth enabled auto-merge (rebase) October 5, 2023 12:49
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0ce3a4f) 68.03% compared to head (cb87341) 68.03%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7639   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16725    16725           
  Branches       2371     2371           
=========================================
  Hits          11379    11379           
  Misses         4363     4363           
  Partials        983      983           
Flag Coverage Δ
funTest-non-docker 36.44% <ø> (ø)
test 35.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit 538ed47 into main Oct 5, 2023
22 checks passed
@sschuberth sschuberth deleted the config-data-classes branch October 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants