feat(pnpm): Add support for PNPM 8.x #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
reviewed
Oct 5, 2023
fviernau
reviewed
Oct 5, 2023
| @@ -70,7 +70,7 @@ class Pnpm( | |||
|
|
|||
| override fun command(workingDir: File?) = if (Os.isWindows) "pnpm.cmd" else "pnpm" | |||
|
|
|||
| override fun getVersionRequirement(): RangesList = RangesListFactory.create("5.* - 7.*") | |||
| override fun getVersionRequirement(): RangesList = RangesListFactory.create("5.* - 8.*") | |||
There was a problem hiding this comment.
The change of the default resolution mode in the change log IIUC may lead to change in dependency resolution results. However, I believe if the lockfile practice is followed, it shouldn't have any effect.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7633 +/- ##
=========================================
Coverage 68.03% 68.03%
Complexity 2023 2023
=========================================
Files 344 344
Lines 16727 16727
Branches 2372 2372
=========================================
Hits 11381 11381
Misses 4363 4363
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously approved these changes
Oct 5, 2023
MarcelBochtler
force-pushed
the
pnpm-8.x
branch
from
63d3ecf to
a520cc8
Compare
MarcelBochtler
force-pushed
the
pnpm-8.x
branch
2 times, most recently
from
530c1a9 to
e252b68
Compare
MarcelBochtler
force-pushed
the
pnpm-8.x
branch
from
e252b68 to
1339ea0
Compare
fviernau
requested changes
Oct 6, 2023
| @@ -14,7 +14,7 @@ NPM_VERSION=8.15.1 | |||
| NUGET_INSPECTOR_VERSION=0.9.12 | |||
| PHP_VERSION=8.1 | |||
| PIPTOOL_VERSION=22.2.2 | |||
| PNPM_VERSION=7.8.0 | |||
| PNPM_VERSION=8.8.0 | |||
There was a problem hiding this comment.
As this upgrade breaks the tests, I was wondering if updating lockfiles should be squashed. I'll leave it up to you. Without squashing I believe it makes sense to at least mention that tests break and lockfiles are updated in a following commit.
MarcelBochtler
force-pushed
the
pnpm-8.x
branch
from
1339ea0 to
b01b886
Compare
fviernau
approved these changes
Oct 6, 2023
According to [1] the only breaking change in PNPM 8.0.0 is that the support for Node.js 14 was dropped, which is not relevant for ORT's PNPM implementation. [1]: https://github.com/pnpm/pnpm/blob/main/pnpm/CHANGELOG.md#800 Signed-off-by: Marcel Bochtler <[email protected]>
See [1] for the changelog. The lockfiles of the synthetic FunTests are no longer compatible with this PNPM version, therefore update them as well to fix this error: ``` ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE Cannot perform a frozen installation because the version of the lockfile is incompatible with this version of pnpm Try either: 1. Aligning the version of pnpm that generated the lockfile with the version that installs from it, or 2. Migrating the lockfile so that it is compatible with the newer version of pnpm, or 3. Using "pnpm install --no-frozen-lockfile" Note that in CI environments, this setting is enabled by default. ``` [1]: https://github.com/pnpm/pnpm/blob/main/pnpm/CHANGELOG.md#880 Signed-off-by: Marcel Bochtler <[email protected]>
MarcelBochtler
force-pushed
the
pnpm-8.x
branch
from
b01b886 to
3320e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 1 the only breaking change in PNPM 8.0.0 is that the support for Node.js 14 was dropped, which is not relevant for ORT's PNPM implementation.
Breaking change
The upgrade to PNPM 8.8.0 in the Docker image will cause analyzing PNPM projects that were created using PNPM 7.x resulting in an error.
To fix this, one has to update the PNPM lockfile using version PNPM version 8.0.0 or newer.