build: If on a pre-release, use the SemVer with SHA1 metadata #7625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
reviewed
Oct 4, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7625 +/- ##
=========================================
Coverage 68.03% 68.03%
Complexity 2022 2022
=========================================
Files 344 344
Lines 16725 16725
Branches 2371 2371
=========================================
Hits 11379 11379
Misses 4363 4363
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously approved these changes
Oct 4, 2023
fviernau
force-pushed
the
pre-release-semver
branch
from
0e3fcae to
5747aa6
Compare
The `rename()` function's source argument is interpreted as a regex. Escape any special chars to support e.g. `+` as part of the file name. Signed-off-by: Sebastian Schuberth <[email protected]>
SemVers may contain `+` as part of the "build" suffix. Signed-off-by: Sebastian Schuberth <[email protected]>
This results the version string for a non-tagged commit to be something like `3.0.0-SNAPSHOT+032.sha.2ad228b`. The version string for a tagged commit is not affected. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
pre-release-semver
branch
from
5747aa6 to
a573a40
Compare
fviernau
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.