fix(docker): Enable build on schedule event #7617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7617 +/- ##
=========================================
Coverage 68.05% 68.05%
Complexity 2023 2023
=========================================
Files 344 344
Lines 16736 16736
Branches 2371 2371
=========================================
Hits 11389 11389
Misses 4364 4364
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
requested changes
Oct 4, 2023
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
from
229296d to
7607ccf
Compare
heliocastro
changed the title
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
from
7607ccf to
4a4aeeb
Compare
tsteenbe
previously approved these changes
Oct 4, 2023
fviernau
previously approved these changes
Oct 5, 2023
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
2 times, most recently
from
8b6789e to
f95dc9c
Compare
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
2 times, most recently
from
b469340 to
07b287d
Compare
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
from
07b287d to
e95f1c9
Compare
|
@fviernau @tsteenbe @sschuberth Anyone can push this one before tomorrow 4AM schedule ? |
|
@fviernau The pr is clean, can we go with approval now ? |
To reduce the frequency of docker builds, on commit e3bbcdb the workflow moved from push based to schedule based. The registry publishing was attached to push and worflow_dispatch events, therefore, any schedule event was ignored. Since builds now happens once a day and in case of version tag, registry publish is now set to be valid on all build cases. For extended image, the time schedule set was removed and only when runtime main docker workflow has their build complete triggers the extended workflow using wokrflow_run dependency. Signed-off-by: Helio Chissini de Castro <[email protected]>
heliocastro
force-pushed
the
heliocastro/docker_extended_build
branch
from
e95f1c9 to
0de9d53
Compare
heliocastro
changed the title
tsteenbe
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After move to scheduled build, main images are building only on push and workflow_dispatch events.
Noticed after some mistake PR done on Ort Github CI repository.