Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM native image build improvements #7607

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

JGit's SSH transport depends on MINA's sshd-sftp although that
dependency is optional [1] and not required for pure SSH connections. So
remove that dependency, which also solves a class initialization issue
when building GraalVM native images.

[1]: https://github.com/apache/mina-sshd/blob/master/docs/sftp.md

Signed-off-by: Sebastian Schuberth <[email protected]>
Even if the code to configure the GraalVM native `imageName` is reached
before the `applicationName` is set in the actual project that applies the
conventions plugin, still use the correct name by evaluating it lazily.

Signed-off-by: Sebastian Schuberth <[email protected]>
With this, the native image build actually succeeds when using the
latest developer build [1].

[1]: https://github.com/graalvm/graalvm-ce-dev-builds/releases/tag/24.0.0-dev-20230928_2125

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner September 29, 2023 21:24
@sschuberth sschuberth enabled auto-merge (rebase) September 29, 2023 21:31
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5389da0) 68.03% compared to head (eab497f) 68.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7607   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16724    16724           
  Branches       2371     2371           
=========================================
  Hits          11378    11378           
  Misses         4363     4363           
  Partials        983      983           
Flag Coverage Δ
funTest-docker 69.36% <ø> (ø)
funTest-non-docker 36.44% <ø> (ø)
test 35.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit b72436d into main Oct 1, 2023
22 checks passed
@sschuberth sschuberth deleted the graalvm-strict-image-heap branch October 1, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants