Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Bring back NodeJS arg to local docker_build script #7606

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

heliocastro
Copy link
Contributor

No description provided.

@heliocastro heliocastro added the bug Issues that are considered to be bugs label Sep 29, 2023
@heliocastro heliocastro self-assigned this Sep 29, 2023
@heliocastro heliocastro requested a review from a team as a code owner September 29, 2023 15:28
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5389da0) 68.03% compared to head (6336b10) 68.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7606   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16724    16724           
  Branches       2371     2371           
=========================================
  Hits          11378    11378           
  Misses         4363     4363           
  Partials        983      983           
Flag Coverage Δ
funTest-docker 69.36% <ø> (ø)
funTest-non-docker 36.44% <ø> (ø)
test 35.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau merged commit cf14991 into main Oct 2, 2023
22 checks passed
@fviernau fviernau deleted the heliocastro/fix_node_script branch October 2, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are considered to be bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants