-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): Upgrade Python to the latest version #7599
Conversation
Signed-off-by: Frank Viernau <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7599 +/- ##
=========================================
Coverage 68.03% 68.03%
Complexity 2022 2022
=========================================
Files 344 344
Lines 16723 16723
Branches 2370 2370
=========================================
Hits 11377 11377
Misses 4363 4363
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm not sure if this is needed for supporting Python 3.11 with |
I don't have an opinion here as I rarely analyze Python projects. What about @oss-review-toolkit/core-devs? |
Why not give proper instructions how to install multiple pythons with custom docker and done ? |
To me, bumping the default Python version here simple severs as a proof that our functional tests still pass with that version. It's not exclusively / primarily for convenience of our users. |
If one looks at EOL chart, we could establish ORT policy to always support the latest Python version in active support. So, I vote for a merge. |
This prepares for supporting Python version 3.11.
Note: This is done in a separate (from supporting python 3.11 with Pip) PR in order to show that the existing
PoetryFunTest
does not break for the currently used Python version 3.10, whenpoetry
is run under version 3.11.