Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Upgrade Python to the latest version #7599

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Sep 28, 2023

This prepares for supporting Python version 3.11.

Note: This is done in a separate (from supporting python 3.11 with Pip) PR in order to show that the existing PoetryFunTest does not break for the currently used Python version 3.10, when poetry is run under version 3.11.

@fviernau fviernau requested a review from a team as a code owner September 28, 2023 17:05
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e3de27) 68.03% compared to head (6dac18d) 68.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7599   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16723    16723           
  Branches       2370     2370           
=========================================
  Hits          11377    11377           
  Misses         4363     4363           
  Partials        983      983           
Flag Coverage Δ
funTest-docker 69.40% <ø> (ø)
funTest-non-docker 36.44% <ø> (ø)
test 35.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau enabled auto-merge (rebase) September 28, 2023 17:30
@fviernau fviernau disabled auto-merge September 28, 2023 17:57
@fviernau
Copy link
Member Author

I'm not sure if this is needed for supporting Python 3.11 with Pip / Poetry (#7598). I cannot see any indication of need from the tests of that PR. Should we still upgrade Python now, or defer it a bit?

@sschuberth
Copy link
Member

Should we still upgrade Python now, or defer it a bit?

I don't have an opinion here as I rarely analyze Python projects. What about @oss-review-toolkit/core-devs?

@heliocastro
Copy link
Contributor

heliocastro commented Sep 29, 2023

Why not give proper instructions how to install multiple pythons with custom docker and done ?
This can be done on documentation. We already have cases on TNG where i was asked how to have two pythons inside the env.
There's honestly nothing forcing to make 3.11.x default unless we want to have headaches, but in other side, 3.12.x is already banging the door.

@sschuberth
Copy link
Member

Why not give proper instructions how to install multiple pythons with custom docker and done ?

To me, bumping the default Python version here simple severs as a proof that our functional tests still pass with that version. It's not exclusively / primarily for convenience of our users.

@fviernau
Copy link
Member Author

If one looks at EOL chart, we could establish ORT policy to always support the latest Python version in active support.
In the 3.11 case this will make the analysis work for 3.10 in most of the cases. In cases where it doesn't work (in particular for < 3.10 version, the user has to create a contain with also these Python versions installed to make it work).

So, I vote for a merge.

[1] https://endoflife.date/python

@fviernau fviernau merged commit b3fd33a into main Sep 29, 2023
36 checks passed
@fviernau fviernau deleted the upgrade-python branch September 29, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants