Fix several scan storage issues #7584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest tag is more likely to have stored scan results in ClearlyDefined. Signed-off-by: Sebastian Schuberth <[email protected]>
Esp. when passing scan storage configuration via command line options while other storage may be configured in the global `config.yml` it can be beneficial to know what exactly takes effect. Signed-off-by: Sebastian Schuberth <[email protected]>
Emphasize that this is about matching results, not any results. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
This override was not taking into account the `ScannerCriteria` at all, so the default implementation should be used instead. Signed-off-by: Sebastian Schuberth <[email protected]>
ClearlyDefined returns VCS URLs like [1] which makes the provenance matcher fail as it checks for [2] (plus the revision independently). Properly parse the VCS URL returned by ClearlyDefined to fix this. [1]: https://github.com/vdurmont/semver4j/tree/88912638db3f6112a2b345f1638ced33a0a606e1 [2]: https://github.com/vdurmont/semver4j.git Signed-off-by: Sebastian Schuberth <[email protected]>
Previously, the empty `scanResults` were used in log output. Refactor code to avoid that error. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
scan-storage-mismatch-logging
branch
from
5f04640 to
47a2fbb
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7584 +/- ##
=========================================
Coverage 68.03% 68.04%
+ Complexity 2023 2022 -1
=========================================
Files 344 344
Lines 16727 16721 -6
Branches 2371 2369 -2
=========================================
- Hits 11381 11378 -3
Misses 4363 4363
+ Partials 983 980 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Superseded by multiple smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.