Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ort-config-package-curation-provider): Update NuGet identifiers #7551

Merged

Conversation

mnonnenmacher
Copy link
Member

Update the NuGet identifiers used in the
OrtConfigPackageCurationProviderFunTest as they were updated in the ort-config repository 1.

Update the NuGet identifiers used in the
`OrtConfigPackageCurationProviderFunTest` as they were updated in the
ort-config repository [1].

[1]: oss-review-toolkit/ort-config#136

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner September 21, 2023 12:45
@mnonnenmacher mnonnenmacher enabled auto-merge (rebase) September 21, 2023 12:48
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (14cc5f1) 68.02% compared to head (d27f529) 68.02%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7551   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     2023     2023           
=========================================
  Files           343      343           
  Lines         16723    16723           
  Branches       2371     2371           
=========================================
  Hits          11375    11375           
  Misses         4364     4364           
  Partials        984      984           
Flag Coverage Δ
funTest-non-docker 36.46% <ø> (ø)
test 35.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth
Copy link
Member

When I search *.kt* for "NuGet::", I find more (unrelated) occurrences:

"NuGet::Microsoft.ChakraCore:1.10.0"
"NuGet::Microsoft.NETFramework.ReferenceAssemblies.net40:1.0.0-preview.2"

Would you mind fixing them, too, in a new commit of this PR anyway?

@mnonnenmacher
Copy link
Member Author

When I search *.kt* for "NuGet::", I find more (unrelated) occurrences:

"NuGet::Microsoft.ChakraCore:1.10.0"
"NuGet::Microsoft.NETFramework.ReferenceAssemblies.net40:1.0.0-preview.2"

Would you mind fixing them, too, in a new commit of this PR anyway?

I will do it in a separate PR to get this test fix merged faster.

@mnonnenmacher mnonnenmacher merged commit eadb556 into main Sep 21, 2023
22 checks passed
@mnonnenmacher mnonnenmacher deleted the fix-ort-config-package-curation-provider-fun-test branch September 21, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants