fix(Scanner): Apply detectedLicenseMapping to FossId findings

[MarcelBochtler]

While the detectedLicenseMappings are globally applied for the other
scanners, these mappings are not applied for FossId. This is because
FossId works different from other scanners as a "remote" scanner.

Apply the mappings to FossId results as well. This fixes a regression
introduced in cdecb9b.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a7d3f5) 68.02% compared to head (c35212f) 68.02%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7537   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     2023     2023           
=========================================
  Files           343      343           
  Lines         16723    16723           
  Branches       2371     2371           
=========================================
  Hits          11375    11375           
  Misses         4364     4364           
  Partials        984      984           

Flag	Coverage Δ
test	35.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sschuberth]

This fixes a regression introduced in cdecb9b.

Sorry for having broken this. The intention of my commit was to "centralize" the mapping on the scanner-level, I just accidentally only applied it to path scanners. With FossId being a package scanner, can't we do the same centralization for package scanners (or even more ideally, for any scanner) instead of only applying it to FossId?

[MarcelBochtler]

With FossId being a package scanner, can't we do the same centralization for package scanners (or even more ideally, for any scanner) instead of only applying it to FossId?

I tried that. See: https://github.com/oss-review-toolkit/ort/compare/fb82e67c4972fc1e707a3c0735336206bd2e1b74..1385d27ac7ce6d1c22e4dec19e1bea26a704b88d (the removed code).

This was not working in my tests.
I don't see if or which central method FossID is using. That's why I implemented it in FossID directly.

[mnonnenmacher]

With FossId being a package scanner, can't we do the same centralization for package scanners (or even more ideally, for any scanner) instead of only applying it to FossId?

I tried that. See: https://github.com/oss-review-toolkit/ort/compare/fb82e67c4972fc1e707a3c0735336206bd2e1b74..1385d27ac7ce6d1c22e4dec19e1bea26a704b88d (the removed code).

This was not working in my tests. I don't see if or which central method FossID is using. That's why I implemented it in FossID directly.

I looked at the diff and am really surprised that it didn't work, I don't understand why it shouldn't. I would be fine with merging this as a quick fix, but could you please add a TODO comment that the mapping of licenses should be moved to a central location?