fix(osv): Align Reference.Type with spec version 1.6.0
#7535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Osv` backend returns JSON data compliant with spec version 1.6.0, while ORT's handling hasn't been updated to that (latest) version. For example, the root cause of [2] is that `Reference.Type` is lacking the value `EVIDENCE`. Align only the values of `Reference.Type` with version 1.6.0 in order to fix [2] quickly. In a future change, remaining alignments, if any, should be made. [1] https://github.com/ossf/osv-schema/blob/v1.6.0/validation/schema.json [2] #7531 Signed-off-by: Frank Viernau <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7535 +/- ##
=========================================
Coverage 68.02% 68.02%
Complexity 2023 2023
=========================================
Files 343 343
Lines 16723 16723
Branches 2371 2371
=========================================
Hits 11375 11375
Misses 4364 4364
Partials 984 984
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Osvbackend returns JSON data compliant with spec version 1.6.0, while ORT's handling hasn't been updated to that (latest) version.For example, the root cause of [2] is that
Reference.Typeis lacking the valueEVIDENCE.Align only the values of
Reference.Typewith version 1.6.0 in order to fix [2] quickly. In a future change, remaining alignments, if any, should be made.[1] https://github.com/ossf/osv-schema/blob/v1.6.0/validation/schema.json
[2] #7531
Fixes #7531.
Follow-up work: #7534.