test(oss-index): Use coordinates as keys

Improve output of assertion failures within `forAll`. Signed-off-by: Frank Viernau <[email protected]>
oss-review-toolkit · Dec 13, 2024 · faf772b · faf772b
1 parent f2003e7
commit faf772b
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/plugins/advisors/oss-index/src/test/kotlin/OssIndexTest.kt b/plugins/advisors/oss-index/src/test/kotlin/OssIndexTest.kt
@@ -122,13 +122,15 @@ class OssIndexTest : WordSpec({
                 OssIndexConfiguration("http://localhost:${server.port()}", null, null)
             )
 
-            val result = ossIndex.retrievePackageFindings(PACKAGES).mapKeys { it.key.id }
-
-            result.keys shouldContainExactlyInAnyOrder PACKAGES.map { it.id }
-            result.forAll { (_, advisorResult) ->
-                advisorResult.advisor shouldBe ossIndex.details
-                advisorResult.vulnerabilities should beEmpty()
-                advisorResult.summary.issues shouldHaveSingleElement { it.severity == Severity.ERROR }
+            val result = ossIndex.retrievePackageFindings(PACKAGES).mapKeys { it.key.id.toCoordinates() }
+
+            result.keys shouldContainExactlyInAnyOrder PACKAGES.map { it.id.toCoordinates() }
+            result.keys.forAll { coordinates ->
+                with(result.getValue(coordinates)) {
+                    advisor shouldBe ossIndex.details
+                    vulnerabilities should beEmpty()
+                    summary.issues shouldHaveSingleElement { it.severity == Severity.ERROR }
+                }
             }
         }