refactor(gradle-inspector): Simplify check for zero byte artifacts

Replace the combination of `takeUnless` and `run` with a simple `if` to improve readability. Signed-off-by: Martin Nonnenmacher <[email protected]>
oss-review-toolkit · Feb 19, 2024 · efc2310 · efc2310
1 parent 44fc219
commit efc2310
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/plugins/package-managers/gradle-inspector/src/main/kotlin/GradleInspector.kt b/plugins/package-managers/gradle-inspector/src/main/kotlin/GradleInspector.kt
@@ -376,12 +376,13 @@ private fun GradleInspector.createRemoteArtifact(
     val checksum = okHttpClient.downloadText("$artifactUrl.$algorithm")
         .getOrElse { return RemoteArtifact.EMPTY }
 
+    val hash = parseChecksum(checksum, algorithm)
+
     // Ignore file with zero byte size, because it cannot be a valid archive.
-    val hash = parseChecksum(checksum, algorithm).takeUnless { it.value == ZERO_BYTES_FILE_SHA1 }
-        ?: run {
-            logger.info("Ignoring zero byte size artifact: $artifactUrl.")
-            return RemoteArtifact.EMPTY
-        }
+    if (hash.value == ZERO_BYTES_FILE_SHA1) {
+        logger.info("Ignoring zero byte size artifact: $artifactUrl.")
+        return RemoteArtifact.EMPTY
+    }
 
     return RemoteArtifact(artifactUrl, hash)
 }