test(node): Add another test case for parseNpmVcsInfo()

The repository nodes can be textual, see [1]. Add a test to clarify the parsing works for that. [1]: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository Signed-off-by: Frank Viernau <[email protected]>
oss-review-toolkit · Apr 12, 2024 · dde0365 · dde0365
1 parent b4d70ad
commit dde0365
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/plugins/package-managers/node/src/test/kotlin/utils/NpmSupportTest.kt b/plugins/package-managers/node/src/test/kotlin/utils/NpmSupportTest.kt
@@ -192,7 +192,7 @@ class NpmSupportTest : WordSpec({
     }
 
     "parseNpmVcsInfo()" should {
-        "get VCS information from an object node" {
+        "get VCS information from an object node containing a repository node which is an object" {
             val node = """
             {    
                 "gitHead": "bar",
@@ -211,6 +211,21 @@ class NpmSupportTest : WordSpec({
                 "foo"
             )
         }
+
+        "get VCS information from an object node containing a repository node which is textual" {
+            val node = """
+            {    
+                "gitHead": "bar",
+                "repository": "git+ssh://example.com/a/b.git" 
+            }
+            """.readJsonTree()
+
+            parseNpmVcsInfo(node) shouldBe VcsInfo(
+                VcsType.UNKNOWN,
+                "git+ssh://example.com/a/b.git",
+                "bar"
+            )
+        }
     }
 
     "splitNpmNamespaceAndName()" should {