Skip to content

Commit

Permalink
fix(go): Disable the GOPATH mode to fix the fun tests
Browse files Browse the repository at this point in the history
Recently, the fun tests for `GoDep` started failing which was roughly
at the same time as the major version upgrade to 1.22.0 in ORT's docker
image. As the GOPATH mode will eventually be removed ^[1], just disable
it now to fix the tests. In particular, do so even though the root cause
of the failing tests is unkown, as `GoDep` is rather outdated and thus
cannot satisfy putting in further efforts.

[1]: golang/go#41330 (comment)

Signed-off-by: Frank Viernau <[email protected]>
  • Loading branch information
fviernau committed Feb 21, 2024
1 parent 90083ca commit a5530e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/package-managers/go/src/main/kotlin/GoDep.kt
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ private fun resolveProjectRoot(definitionFile: File) =
private fun resolveVcsInfo(importPath: String, revision: String, gopath: File): VcsInfo {
val pc = ProcessCapture(
"go", "get", "-d", importPath,
environment = mapOf("GOPATH" to gopath.path, "GO111MODULE" to "off")
environment = mapOf("GOPATH" to gopath.path)
)

// HACK Some failure modes from "go get" can be ignored:
Expand Down

0 comments on commit a5530e1

Please sign in to comment.