fix(askalono): Correctly handle errors in results

The result structure contains either a "result" or an "error" key. Signed-off-by: Haiko Schol <[email protected]>
oss-review-toolkit · Feb 9, 2024 · a547091 · a547091
1 parent 4e3b23f
commit a547091
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/plugins/scanners/askalono/src/main/kotlin/Askalono.kt b/plugins/scanners/askalono/src/main/kotlin/Askalono.kt
@@ -97,13 +97,13 @@ class Askalono internal constructor(name: String, private val wrapperConfig: Sca
         )
 
         results.forEach {
-            if (it.error == null) {
+            if (it.result != null) {
                 licenseFindings += LicenseFinding(
                     license = it.result.license.name,
                     location = TextLocation(it.path, TextLocation.UNKNOWN_LINE),
                     score = it.result.score
                 )
-            } else {
+            } else if (it.error != null) {
                 issues += Issue(
                     source = name,
                     message = it.error,

diff --git a/plugins/scanners/askalono/src/main/kotlin/AskalonoResultModel.kt b/plugins/scanners/askalono/src/main/kotlin/AskalonoResultModel.kt
@@ -24,7 +24,7 @@ import kotlinx.serialization.Serializable
 @Serializable
 data class AskalonoResult(
     val path: String,
-    val result: PathResult,
+    val result: PathResult? = null,
     val error: String? = null
 )