Skip to content

Commit

Permalink
chore(commands): Deprecate the --skip-excluded options
Browse files Browse the repository at this point in the history
This is a follow-up to 67297b2.

Signed-off-by: Sebastian Schuberth <[email protected]>
  • Loading branch information
sschuberth committed Dec 14, 2023
1 parent 6c5ef66 commit 979847b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion plugins/commands/advisor/src/main/kotlin/AdvisorCommand.kt
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import com.github.ajalt.clikt.core.terminal
import com.github.ajalt.clikt.parameters.options.associate
import com.github.ajalt.clikt.parameters.options.convert
import com.github.ajalt.clikt.parameters.options.default
import com.github.ajalt.clikt.parameters.options.deprecated
import com.github.ajalt.clikt.parameters.options.flag
import com.github.ajalt.clikt.parameters.options.option
import com.github.ajalt.clikt.parameters.options.required
Expand Down Expand Up @@ -106,7 +107,7 @@ class AdvisorCommand : OrtCommand(
private val skipExcluded by option(
"--skip-excluded",
help = "Do not check excluded projects or packages."
).flag()
).flag().deprecated("Use the global option 'ort -P ort.advisor.skipExcluded=... advise' instead.")

override fun run() {
val outputFiles = outputFormats.mapTo(mutableSetOf()) { format ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.github.ajalt.clikt.parameters.groups.required
import com.github.ajalt.clikt.parameters.groups.single
import com.github.ajalt.clikt.parameters.options.convert
import com.github.ajalt.clikt.parameters.options.default
import com.github.ajalt.clikt.parameters.options.deprecated
import com.github.ajalt.clikt.parameters.options.flag
import com.github.ajalt.clikt.parameters.options.option
import com.github.ajalt.clikt.parameters.options.required
Expand Down Expand Up @@ -190,7 +191,7 @@ class DownloaderCommand : OrtCommand(
private val skipExcluded by option(
"--skip-excluded",
help = "Do not download excluded projects or packages. Works only with the '--ort-file' parameter."
).flag()
).flag().deprecated("Use the global option 'ort -P ort.downloader.skipExcluded=... download' instead.")

private val dryRun by option(
"--dry-run",
Expand Down
3 changes: 2 additions & 1 deletion plugins/commands/scanner/src/main/kotlin/ScannerCommand.kt
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.github.ajalt.clikt.parameters.options.RawOption
import com.github.ajalt.clikt.parameters.options.associate
import com.github.ajalt.clikt.parameters.options.convert
import com.github.ajalt.clikt.parameters.options.default
import com.github.ajalt.clikt.parameters.options.deprecated
import com.github.ajalt.clikt.parameters.options.flag
import com.github.ajalt.clikt.parameters.options.option
import com.github.ajalt.clikt.parameters.options.required
Expand Down Expand Up @@ -118,7 +119,7 @@ class ScannerCommand : OrtCommand(
private val skipExcluded by option(
"--skip-excluded",
help = "Do not scan excluded projects or packages. Works only with the '--ort-file' parameter."
).flag()
).flag().deprecated("Use the global option 'ort -P ort.scanner.skipExcluded=... scan' instead.")

private val resolutionsFile by option(
"--resolutions-file",
Expand Down

0 comments on commit 979847b

Please sign in to comment.