Skip to content

Commit

Permalink
chore(scancode): Print JSON raw results non-pretty
Browse files Browse the repository at this point in the history
ScanCode's raw JSON results are not exposed by ORT and thus not looked
at by humans. So disable pretty-printing for the chance of a tad quicker
result generation.

Signed-off-by: Sebastian Schuberth <[email protected]>
  • Loading branch information
sschuberth committed Dec 17, 2024
1 parent 3cb5f2b commit 5007b81
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions gradle/gradle-daemon-jvm.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# The version of the JDK to use for building ORT.
# Keep this aligned with `javaLanguageVersion` in `gradle.properties`.
toolchainVersion = 21
toolchainVendor = Adoptium
2 changes: 1 addition & 1 deletion plugins/scanners/scancode/src/main/kotlin/ScanCode.kt
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class ScanCode internal constructor(
const val SCANNER_NAME = "ScanCode"

private const val LICENSE_REFERENCES_OPTION_VERSION = "32.0.0"
private const val OUTPUT_FORMAT_OPTION = "--json-pp"
private const val OUTPUT_FORMAT_OPTION = "--json"
}

class Factory : ScannerWrapperFactory<ScanCodeConfig>(SCANNER_NAME) {
Expand Down
4 changes: 2 additions & 2 deletions plugins/scanners/scancode/src/test/kotlin/ScanCodeTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ScanCodeTest : WordSpec({

"configuration" should {
"return the default values if the scanner configuration is empty" {
scanner.configuration shouldBe "--copyright --license --info --strip-root --timeout 300 --json-pp"
scanner.configuration shouldBe "--copyright --license --info --strip-root --timeout 300 --json"
}

"return the non-config values from the scanner configuration" {
Expand All @@ -57,7 +57,7 @@ class ScanCodeTest : WordSpec({

val scannerWithConfig = ScanCode("ScanCode", config, ScannerWrapperConfig.EMPTY)

scannerWithConfig.configuration shouldBe "--command --line --json-pp"
scannerWithConfig.configuration shouldBe "--command --line --json"
}
}

Expand Down

0 comments on commit 5007b81

Please sign in to comment.