style(detekt): Enable the "MissingPackageDeclaration" rule

Enable the "MissingPackageDeclaration" rule [1] to ensure that all Kotlin source files have a package declaration. [1]: https://detekt.dev/docs/rules/potential-bugs#missingpackagedeclaration Signed-off-by: Nicolas Nobelis <[email protected]>
oss-review-toolkit · Oct 2, 2023 · 3207d1e · 3207d1e
1 parent 0057704
commit 3207d1e
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 8 deletions.
diff --git a/.detekt.yml b/.detekt.yml
@@ -94,6 +94,11 @@ style:
       - kotlinx.html.*
       - kotlinx.html.dom.*
 
+potential-bugs:
+  MissingPackageDeclaration:
+    active: true
+    excludes: ["**/GradleModel.kt", "**/build.gradle.kts"]
+
 ORT:
   OrtImportOrder:
     active: true

diff --git a/advisor/src/funTest/kotlin/OsvFunTest.kt b/advisor/src/funTest/kotlin/OsvFunTest.kt
@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+package org.ossreviewtoolkit.advisor
+
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
 import io.kotest.matchers.shouldBe

diff --git a/clients/osv/src/funTest/kotlin/OsvServiceFunTest.kt b/clients/osv/src/funTest/kotlin/OsvServiceFunTest.kt
@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+package org.ossreviewtoolkit.clients.osv
+
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
 import io.kotest.matchers.result.shouldBeSuccess
@@ -26,11 +28,6 @@ import java.time.Instant
 
 import kotlinx.serialization.json.JsonObject
 
-import org.ossreviewtoolkit.clients.osv.OsvApiClient
-import org.ossreviewtoolkit.clients.osv.OsvService
-import org.ossreviewtoolkit.clients.osv.Package
-import org.ossreviewtoolkit.clients.osv.VulnerabilitiesForPackageRequest
-import org.ossreviewtoolkit.clients.osv.Vulnerability
 import org.ossreviewtoolkit.utils.test.getAssetAsString
 
 private val VULNERABILITY_FOR_PACKAGE_BY_COMMIT_REQUEST = VulnerabilitiesForPackageRequest(

diff --git a/clients/scanoss/src/test/kotlin/ScanOssDetailsTest.kt b/clients/scanoss/src/test/kotlin/ScanOssDetailsTest.kt
@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+package org.ossreviewtoolkit.clients.scanoss
+
 import com.github.tomakehurst.wiremock.WireMockServer
 import com.github.tomakehurst.wiremock.core.WireMockConfiguration
 
@@ -34,7 +36,6 @@ import okhttp3.MediaType.Companion.toMediaType
 import okhttp3.MultipartBody
 import okhttp3.RequestBody.Companion.asRequestBody
 
-import org.ossreviewtoolkit.clients.scanoss.ScanOssService
 import org.ossreviewtoolkit.clients.scanoss.model.Source
 import org.ossreviewtoolkit.utils.test.shouldNotBeNull
 

diff --git a/clients/scanoss/src/test/kotlin/ScanOssServiceTest.kt b/clients/scanoss/src/test/kotlin/ScanOssServiceTest.kt
@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+package org.ossreviewtoolkit.clients.scanoss
+
 import com.github.tomakehurst.wiremock.WireMockServer
 import com.github.tomakehurst.wiremock.core.WireMockConfiguration
 
@@ -33,7 +35,6 @@ import okhttp3.MediaType.Companion.toMediaType
 import okhttp3.MultipartBody
 import okhttp3.RequestBody.Companion.asRequestBody
 
-import org.ossreviewtoolkit.clients.scanoss.ScanOssService
 import org.ossreviewtoolkit.clients.scanoss.model.IdentificationType
 import org.ossreviewtoolkit.utils.test.shouldNotBeNull
 

diff --git a/...tion-providers/ort-config/src/test/kotlin/OrtConfigPackageConfigurationProviderFunTest.kt b/...tion-providers/ort-config/src/test/kotlin/OrtConfigPackageConfigurationProviderFunTest.kt
@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+package org.ossreviewtoolkit.plugins.packageconfigurationproviders.ortconfig
+
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.collections.beEmpty
 import io.kotest.matchers.collections.haveSize
@@ -26,7 +28,6 @@ import org.ossreviewtoolkit.model.ArtifactProvenance
 import org.ossreviewtoolkit.model.Hash
 import org.ossreviewtoolkit.model.Identifier
 import org.ossreviewtoolkit.model.RemoteArtifact
-import org.ossreviewtoolkit.plugins.packageconfigurationproviders.ortconfig.OrtConfigPackageConfigurationProvider
 
 class OrtConfigPackageConfigurationProviderFunTest : StringSpec({
     "provider can load package-configurations from the ort-config repository" {