chore(osv): Give a variable a more fitting name

In all practical cases, OSV's "score" field holds the CVSS vector string, so rename the variable accordingly to avoid confusion with ORT's "severity" string. Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Dec 5, 2024 · 254809a · 254809a
1 parent 6ebb731
commit 254809a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/plugins/advisors/osv/src/main/kotlin/Osv.kt b/plugins/advisors/osv/src/main/kotlin/Osv.kt
@@ -157,7 +157,7 @@ private fun Vulnerability.toOrtVulnerability(): org.ossreviewtoolkit.model.vulne
         it.type.name to it.score
     }.ifEmpty {
         listOf(null to null)
-    }.forEach { (scoringSystem, severity) ->
+    }.forEach { (scoringSystem, vector) ->
         references.mapNotNullTo(ortReferences) { reference ->
             val url = reference.url.trim().let { if (it.startsWith("://")) "https$it" else it }
 
@@ -169,15 +169,15 @@ private fun Vulnerability.toOrtVulnerability(): org.ossreviewtoolkit.model.vulne
                 val specificSeverity = databaseSpecific?.get("severity")
 
                 val baseScore = runCatching {
-                    CvssVector.parseVector(severity)?.baseScore?.toFloat()
+                    CvssVector.parseVector(vector)?.baseScore?.toFloat()
                 }.onFailure {
-                    logger.debug { "Unable to parse CVSS vector '$severity': ${it.collectMessages()}." }
+                    logger.debug { "Unable to parse CVSS vector '$vector': ${it.collectMessages()}." }
                 }.getOrNull()
 
                 val severityRating = (specificSeverity as? JsonPrimitive)?.contentOrNull
                     ?: VulnerabilityReference.getQualitativeRating(scoringSystem, baseScore)?.name
 
-                VulnerabilityReference(it, scoringSystem, severityRating, baseScore, severity)
+                VulnerabilityReference(it, scoringSystem, severityRating, baseScore, vector)
             }.getOrNull()
         }
     }