feat(sw360-package-curation-provider)!: Use secret options map

Read the authentication credentials from the secrets map instead of the options map in `Sw360PackageCurationProviderFactory`. Signed-off-by: Martin Nonnenmacher <[email protected]>
oss-review-toolkit · Oct 9, 2023 · 247b3de · 247b3de
1 parent 336fa07
commit 247b3de
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/model/src/main/resources/reference.yml b/model/src/main/resources/reference.yml
@@ -72,6 +72,7 @@ ort:
     options:
       restUrl: 'https://your-sw360-rest-url'
       authUrl: 'https://your-authentication-url'
+    secrets:
       username: username
       password: password
       clientId: clientId

diff --git a/model/src/test/kotlin/config/OrtConfigurationTest.kt b/model/src/test/kotlin/config/OrtConfigurationTest.kt
@@ -85,7 +85,9 @@ class OrtConfigurationTest : WordSpec({
                     type = "SW360",
                     options = mapOf(
                         "restUrl" to "https://your-sw360-rest-url",
-                        "authUrl" to "https://your-authentication-url",
+                        "authUrl" to "https://your-authentication-url"
+                    ),
+                    secrets = mapOf(
                         "username" to "username",
                         "password" to "password",
                         "clientId" to "clientId",

diff --git a/plugins/package-curation-providers/sw360/src/main/kotlin/Sw360PackageCurationProvider.kt b/plugins/package-curation-providers/sw360/src/main/kotlin/Sw360PackageCurationProvider.kt
@@ -57,11 +57,11 @@ class Sw360PackageCurationProviderFactory : PackageCurationProviderFactory<Sw360
         Sw360StorageConfiguration(
             restUrl = options.getValue("restUrl"),
             authUrl = options.getValue("authUrl"),
-            username = options.getValue("username"),
-            password = options["password"].orEmpty(),
-            clientId = options.getValue("clientId"),
-            clientPassword = options["clientPassword"].orEmpty(),
-            token = options["token"].orEmpty()
+            username = secrets.getValue("username"),
+            password = secrets["password"].orEmpty(),
+            clientId = secrets.getValue("clientId"),
+            clientPassword = secrets["clientPassword"].orEmpty(),
+            token = secrets["token"].orEmpty()
         )
 }