perf(downloader): Return early from archive download for an empty rev…

…ision This avoids trying to download from an invalid archive URL, improving the performance when running e.g. `ort download --dry-run`. Note that the change in the static version of `toArchiveDownloadUrl()` is only done for consistency. Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Feb 19, 2024 · 13d7611 · 13d7611
1 parent 263b64d
commit 13d7611
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/downloader/src/main/kotlin/VcsHost.kt b/downloader/src/main/kotlin/VcsHost.kt
@@ -425,6 +425,7 @@ enum class VcsHost(
          */
         fun toArchiveDownloadUrl(vcsInfo: VcsInfo): String? {
             val normalizedVcsInfo = vcsInfo.normalize()
+            if (normalizedVcsInfo.revision.isEmpty()) return null
             val host = entries.find { it.isApplicable(normalizedVcsInfo) } ?: return null
 
             return normalizedVcsInfo.url.toUri {
@@ -518,7 +519,7 @@ enum class VcsHost(
      */
     fun toArchiveDownloadUrl(vcsInfo: VcsInfo): String? {
         val normalizedVcsInfo = vcsInfo.normalize()
-        if (!isApplicable(normalizedVcsInfo)) return null
+        if (normalizedVcsInfo.revision.isEmpty() || !isApplicable(normalizedVcsInfo)) return null
 
         return normalizedVcsInfo.url.toUri {
             val userOrOrg = getUserOrOrgInternal(it) ?: return@toUri null