refactor(npm): Stop creating analyzer issues for deprecation warnings

Using analyzer issues for deprecation warnings seems inappropriate. The
concern of the analyzer is to create a correct dependency tree. If that
construction is successful there should be no issues.

Signed-off-by: Frank Viernau <[email protected]>

plugins/package-managers/node/src/funTest/assets/projects/synthetic/npm-expected-output.yml

@@ -1193,8 +1193,3 @@ issues:
     \ supplemental metadata must be fetched from the registry. This is a one-time\
     \ fix-up, please be patient..."
   severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: CoffeeScript on NPM has moved to \"coffeescript\"\
-    \ (no hyphen)"
-  severity: "WARNING"

plugins/package-managers/node/src/funTest/assets/projects/synthetic/npm-version-urls-expected-output.yml

@@ -5149,48 +5149,6 @@ packages:
     revision: "37816c0e2e25da2901d584442235946d5cd8c80d"
     path: ""
 issues:
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Removed event-stream from gulp-header"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Please upgrade to v0.1.7"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Please upgrade to v1.0.1"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Please upgrade to v0.1.5"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Please upgrade to v1.0.1"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Legacy versions of mkdirp are no longer supported.\
-    \ Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises\
-    \ in 1.x.)"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated"
-  severity: "WARNING"
-- timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
-  message: "deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated"
-  severity: "WARNING"
 - timestamp: "1970-01-01T00:00:00Z"
   source: "NPM"
   message: "skipping integrity check for git dependency ssh://[email protected]/jonschlinkert/gulp-format-md.git "

plugins/package-managers/node/src/main/kotlin/Npm.kt

@@ -634,8 +634,8 @@ private fun nodeModulesDirForPackageJson(packageJson: File): File? {
 }
 
 private fun List<String>.groupLines(marker: String): List<String> {
-    val ignorableLinePrefixes = setOf("code ", "errno ", "path ", "syscall ")
-    val singleLinePrefixes = setOf("deprecated ", "skipping integrity check for git dependency ")
+    val ignorableLinePrefixes = setOf("code ", "deprecated ", "errno ", "path ", "syscall ")
+    val singleLinePrefixes = setOf("skipping integrity check for git dependency ")
     val minCommonPrefixLength = 5
 
     val issueLines = mapNotNull { line ->