refactor(model): Introduce a lazy severity rating property

Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Oct 30, 2023 · 002a57a · 002a57a
1 parent 9ed1fb4
commit 002a57a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/model/src/main/kotlin/vulnerabilities/VulnerabilityReference.kt b/model/src/main/kotlin/vulnerabilities/VulnerabilityReference.kt
@@ -63,4 +63,9 @@ data class VulnerabilityReference(
                 else -> severity?.uppercase()?.takeIf { it in CVSS3_SEVERITIES }
             } ?: "UNKNOWN"
     }
+
+    /**
+     * Return a human-readable severity rating string.
+     */
+    val severityRating: String by lazy { getSeverityString(scoringSystem, severity) }
 }
diff --git a/plugins/reporters/evaluated-model/src/main/kotlin/EvaluatedModelMapper.kt b/plugins/reporters/evaluated-model/src/main/kotlin/EvaluatedModelMapper.kt
@@ -397,12 +397,7 @@ internal class EvaluatedModelMapper(private val input: ReporterInput) {
         val resolutions = addResolutions(vulnerability)
 
         val evaluatedReferences = vulnerability.references.map {
-            EvaluatedVulnerabilityReference(
-                it.url,
-                it.scoringSystem,
-                it.severity,
-                VulnerabilityReference.getSeverityString(it.scoringSystem, it.severity)
-            )
+            EvaluatedVulnerabilityReference(it.url, it.scoringSystem, it.severity, it.severityRating)
         }
 
         vulnerabilities += EvaluatedVulnerability(