Skip to content

feat(Repository): Use KnownProvenance instead of VcsInfo #15689

feat(Repository): Use KnownProvenance instead of VcsInfo

feat(Repository): Use KnownProvenance instead of VcsInfo #15689

Triggered via pull request June 20, 2024 14:02
Status Failure
Total duration 8m 46s
Artifacts

static-analysis.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 10 warnings, and 1 notice
commit-lint
You have commit messages with errors ⧗ input: feat(Provenance): Add `matches(KnownProvenance)` method In preparation of replacing `VcsInfo` in `Repository` with `KnownProvenances`, we add a method to match `KnownProvenances` against each other. Signed-off-by: Jens Keim <[email protected]> ✖ body's lines must not be longer than 75 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: refactor(Provenance): Allow blank `resolvedRevision` for `VcsInfo.EMPTY` This will allow tests using `Repository` objects using `VcsInfo.EMPTY` to continue to function, even though `RepositoryProvenance` does not usually allow blank revisions. By restricting the exception to `VcsInfo.EMPTY` any other bahaviour of `RepositoryProvenance` should be retained. Some unrelated `OrtResultTest`s had to be given non-blank revisions: Both `fail if no vcs matches` and `use the correct vcs` don't hinge on the given blank revision, so to assure they do not fail for unrelated reasons, we just add the default git revision "main" to these example repos. Signed-off-by: Jens Keim <[email protected]> ✖ body's lines must not be longer than 75 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
detekt-issues
Process completed with exit code 1.
Unresolved reference in KDoc: reporter/src/main/kotlin/StatisticsCalculator.kt#L37
Cannot resolve symbol 'RuleViolationResolution'
Unresolved reference in KDoc: reporter/src/main/kotlin/StatisticsCalculator.kt#L36
Cannot resolve symbol 'IssueResolution'
Unresolved reference in KDoc: model/src/main/kotlin/licenses/LicenseInfo.kt#L141
Cannot resolve symbol 'nestedRepositories'
Unresolved reference in KDoc: helper-cli/src/main/kotlin/utils/Extensions.kt#L203
Cannot resolve symbol 'RuleViolation'
Unresolved reference in KDoc: model/src/main/kotlin/Repository.kt#L43
Cannot resolve symbol 'ORT_REPO_CONFIG_FILENAME'
Unresolved reference in KDoc: model/src/main/kotlin/licenses/LicenseInfo.kt#L144
Cannot resolve symbol 'RepositoryConfiguration'
Class member can have 'private' visibility: model/src/main/kotlin/Repository.kt#L48
Property 'DEFAULT_REVISION' could be private