graceful restart: send initial paths list to all neighbors #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, when graceful restart was configured for a neighbor and when the restart flag was set by the restarting speaker, if the neighbor was not advertising the GR capability, the initial paths list was never sent by the restarting speaker to its neighbor This is a problem when the server is configured with graceful restart for all its peers without knowing if the peer supports it. If some of the peers don't support it, they may never receive the routes from the restarting speaker, leading to an inconsistent routing state.
|
Thanks a lot! |
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 10, 2024
To pull-in the recent fix (osrg/gobgp#2803). Signed-off-by: Yutaro Hayakawa <[email protected]>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 24, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596). Fixes: cilium#32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 24, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596). Fixes: cilium#32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 24, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596). Fixes: cilium#32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 24, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596) Fixes: cilium#32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
YutaroHayakawa
added a commit
to YutaroHayakawa/cilium
that referenced
this pull request
Jun 27, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596) Fixes: cilium#32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
julianwiedmann
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 2, 2024
To pull-in the recent fix (osrg/gobgp#2803) for the issue (osrg/gobgp#2596) Fixes: #32886 Signed-off-by: Yutaro Hayakawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when graceful restart was configured for a neighbor and when the restart flag was set by the restarting speaker, if the neighbor was not advertising the GR capability, the initial paths list was never sent by the restarting speaker to its neighbor
This is a problem when the server is configured with graceful restart for all its peers without knowing if the peer supports it. If some of the peers don't support it, they may never receive the routes from the restarting speaker, leading to an inconsistent routing state.
@fujita, I closed previous PR #2794 and re-created this new one with some modification based on the discussion there