Sending Cease/Hard Reset notification #2800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the commit message here:
Our use case for this is letting users of Cilium BGP Control Plane hard reset the session when they service out the node for maintenance. In the current GoBGP implementation, there's no way to perform a hard reset, so users must wait to shut down the node (shutdown the data plane on the node, in other words) until the graceful restart timer expires. Otherwise, it causes a traffic disruption.
One concern is that this is a breaking change for people who rely on any modified notification message to trigger a graceful restart procedure. I'm ok with hiding this feature behind a flag if it is harmful, but I guess the impact is limited because the document suggests sending
SIGINT
orSIGKILL
to trigger graceful restart procedure. In those cases, GoBGP shutdown the session without any notification, so the procedure will be triggered anyways.