Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommunityCount BGP Policy Condition #2792

Closed
wants to merge 1 commit into from

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Apr 3, 2024

This is intended to have the same behaviour as these OpenConfig paths:

  • /routing-policy/policy-definitions/policy-definition/statements/statement/conditions/bgp-conditions/community-count/config/operator
  • /routing-policy/policy-definitions/policy-definition/statements/statement/conditions/bgp-conditions/community-count/config/value

@fujita
Copy link
Member

fujita commented Apr 4, 2024

Hmm, why two commits have the same message (93fcdf7 and 9cb5f87)?

This is intended to have the same behaviour as [these OpenConfig paths](https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-routing-policy.html#routing-policy-policy-definitions-policy-definition-statements-statement-conditions-bgp-conditions-community-count):
* /routing-policy/policy-definitions/policy-definition/statements/statement/conditions/bgp-conditions/community-count/config/operator
* /routing-policy/policy-definitions/policy-definition/statements/statement/conditions/bgp-conditions/community-count/config/value
@wenovus
Copy link
Contributor Author

wenovus commented Apr 4, 2024

Hmm, why two commits have the same message (93fcdf7 and 9cb5f87)?

I first pushed 93fcdf7 but then ran git commit --amend locally in my fork, forgetting I already pushed, and that caused a conflict when I tried to push a new commit, which is resolved by the subsequent merge.

I've fixed the history via a force push now.

@fujita
Copy link
Member

fujita commented Apr 10, 2024

pushed, thanks!

@fujita fujita closed this Apr 10, 2024
@wenovus wenovus deleted the community-count branch April 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants