Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ros distro at runtime #12

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Get ros distro at runtime #12

merged 1 commit into from
Aug 3, 2023

Conversation

koonpeng
Copy link
Member

@koonpeng koonpeng commented Aug 3, 2023

This allows us to use the same release for different ROS versions. After this is merged, we can make a new release so nexus can fetch the correct version.

Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng requested a review from Yadunund August 3, 2023 05:44
@koonpeng
Copy link
Member Author

koonpeng commented Aug 3, 2023

@Yadunund I see the foxy and galactic tests have been removed in #10. I don't mind dropping foxy support, if that is your intention as well, we can clean up the foxy code paths and update the README.

@Yadunund
Copy link
Member

Yadunund commented Aug 3, 2023

@Yadunund I see the foxy and galactic tests have been removed in #10. I don't mind dropping foxy support, if that is your intention as well, we can clean up the foxy code paths and update the README.

Ah yeah we should drop foxy and galatic support since those are EOL.

@koonpeng koonpeng merged commit 0fca6ee into main Aug 3, 2023
1 check passed
@koonpeng koonpeng deleted the kp/get-distro-at-runtime branch August 3, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants