Tune the Ordering for all the atomics #1707
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oso/polar-core/src/counter.rs
Line 10 in d43ed90
oso/polar-core/src/inverter.rs
Line 45 in d43ed90
Here 'next' and 'ID' are global counter between threads and doesn't synchronize with other variables. Although Ordering::SeqCst or Ordering::AcqRel ensures the correctness of the program, it affects the performance of the program. Therefore,
Relaxed
can be used in both single-threaded and multi-threaded environments.While atomic operations using relaxed memory ordering do not provide any happens-before relationship, they do guarantee a total modification order of each individual atomic variable. This means that all modifications of the same atomic variable happen in an order that is the same from the perspective of every single thread.