Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active record adapter enums and multiple joins per table #1626

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Active record adapter enums and multiple joins per table #1626

wants to merge 7 commits into from

Conversation

lp
Copy link
Contributor

@lp lp commented Sep 19, 2022

Why

  • ActiveRecord supports enum methods which needs some translation in the ActiveRecordAdapter
  • Some table-relations requires the same table to be joined multiple-times, like when different ActiveRecord models share the same table

Todo

  • no tests yet to support 👆

@github-actions
Copy link

github-actions bot commented Sep 19, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gj
Copy link
Member

gj commented Oct 12, 2022

@lp gonna mark this one as a draft since it looks like it's still blocked on test coverage (based on the PR description)

@gj gj marked this pull request as draft October 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lp @gj @samscott89