This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
blueprint-reference: add Ignition config section #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
7flying
force-pushed
the
ignition-blueprint
branch
2 times, most recently
from
605d566 to
4fa45c5
Compare
|
Looking for a review on this, the PR that introduced the changes described here has been merged. |
7flying
force-pushed
the
ignition-blueprint
branch
from
4fa45c5 to
2d70660
Compare
|
Updated after some updates made on osbuild/osbuild-composer#3130 |
runcom
reviewed
Jan 12, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
runcom
reviewed
Feb 9, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
7flying
force-pushed
the
ignition-blueprint
branch
3 times, most recently
from
ed4542b to
1ae3a2a
Compare
|
@runcom @elianerpereira changes made, let me know if it makes sense |
runcom
previously approved these changes
Feb 9, 2023
miabbott
reviewed
Feb 9, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
miabbott
reviewed
Feb 9, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
7flying
force-pushed
the
ignition-blueprint
branch
from
1ae3a2a to
54497a7
Compare
|
Updated after @miabbott comments. |
7flying
force-pushed
the
ignition-blueprint
branch
from
54497a7 to
196c108
Compare
|
rebased on main, can I bother you @thozza for a review? This PR has approved but then forgotten and not merged 😢 |
thozza
suggested changes
Mar 9, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
7flying
force-pushed
the
ignition-blueprint
branch
from
196c108 to
555e342
Compare
|
Replaced ISO with image in a couple of places, added full base64 working example, changed paragraphs to be single-line paragraphs, expanded the |
thozza
reviewed
Mar 9, 2023
osbuild-composer/src/blueprint-reference/blueprint-reference.md
Outdated
Show resolved
Hide resolved
7flying
force-pushed
the
ignition-blueprint
branch
from
555e342 to
128508c
Compare
Signed-off-by: Irene Diez <[email protected]>
7flying
force-pushed
the
ignition-blueprint
branch
from
fae84bc to
ba8481d
Compare
runcom
approved these changes
May 8, 2023
|
@supakeen thank you!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info about the new ignition customization.
Please wait until osbuild/osbuild-composer#3161 gets merged to merge this (if approved oc).