main: add new experimental --use-librepo switch
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was generated using: ``` $ go mod edit -replace github.com/osbuild/images=github.com/mvo5/images@librepo-sources-osbuild1974 $ go mod tidy ```
This commit adds a new `--use-librepo` switch that will enable librepo based downloading so that people can play with the new backend.
This is a test commit that switches all tests to the librepo based downloading. Obviously this needs to be more nuanced (well, maybe) and we would make this part of the testcases. Or we just switch everything once osbuild supports librepo because we suffer from the flaky downloads and osbuild will be up-to-date via the container.
This commit adds a workaround for the librepo mirror IDs: osbuild librepo expects the mirrors to be encoded as hex-digests - osbuild-depsolve-dnf gives us this for some repos but when using "SetRootDir" (as we do here) it just gives us the pipeline names, we probably want to fix this either in osbuild:librepo (relaxing the rules) or "images" (always hash the id again) but for now to it here to get some testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as this needs lots of stuff first]
This commit adds a new
--use-libreposwitch that willenable librepo based downloading so that people can play with
the new backend.