bib: add integration test for the new Disk customizations
#721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
7be1324 to
16dcb79
Compare
achilleas-k
reviewed
Nov 22, 2024
mvo5
force-pushed
the
use-new-disk-customizations
branch
3 times, most recently
from
b1af681 to
c8ea8e3
Compare
|
The tests seem fine by themselves but they fail when I run them all at the same time. Meaning, if I run I'll have a look at the pytest fixture handling. |
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
c8ea8e3 to
c04e19f
Compare
mvo5
changed the title
Disk customizationsDisk customizations
This update includes support for swap partitions and logical volumes. See: osbuild/images#1072
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
c04e19f to
d7fb01c
Compare
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
d7fb01c to
1a861bb
Compare
achilleas-k
previously approved these changes
Dec 3, 2024
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
1a861bb to
dafe9e3
Compare
achilleas-k
previously approved these changes
Dec 3, 2024
This commit adds a new integration test that checks for the disk customizations. It exchanges some of the filesystem tests with disk customization tests.
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
dafe9e3 to
89c4475
Compare
achilleas-k
approved these changes
Dec 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[It is draft right now because it has quite a few rough edges in the code but mostly because the LVM case is not working right now and it's unclear why, but pushing it will help with exposure/feedback, there are also some issues in "images" that are uncovered here that should be fixed there (like minsize seems to be not working for strings)]
This PR adds support for the new
Diskcustomizations from osbuild/images#1041 into bib.