bib: resolve container content from the external dnf again #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
resolve-external-again-thanks-achilleask
branch
6 times, most recently
from
5072c4e to
37da578
Compare
mvo5
force-pushed
the
resolve-external-again-thanks-achilleask
branch
2 times, most recently
from
263ae76 to
43f9f88
Compare
achilleas-k
changed the title
achilleas-k
reviewed
Nov 7, 2024
|
Smoke test failed with "Bad gateway" -_- |
achilleas-k
previously approved these changes
Nov 7, 2024
mvo5
force-pushed
the
resolve-external-again-thanks-achilleask
branch
from
43f9f88 to
a3abc6f
Compare
This commit goes back to the approach we had in PR#565 to resolve using the solver from outside of the container. The reason to back is that some containers (like f41) do not have the python dnf available so they break with the "run dnfjson inside" approach (that was meant as a quick fix only anyway). Huge kudos to Achilleas for most of the work here. Co-Authored-By: Achilleas Koutsou <[email protected]>
This commit adds a test that ensures that access to subscribed content works in a nested container similar to how we run the nested container in bootc-image-builder. I.e. here we run in a privilidged container that then runs a normal container to depsolve against that. The test works by running the already existing `TestDNFJsonWorkWithSubscribedContent` inside the container to double check that subscribed content is available both from the host and when nesting. The extra complication is that for efficiency we compile the test binary on the host (to avoid having to have a go toolchain inside the container) which means the container needs to have a recent version of glibc (building our code with CGO_ENABLED=0 does not work) to support developing/running tests on f41.
mvo5
force-pushed
the
resolve-external-again-thanks-achilleask
branch
from
a3abc6f to
41f3a90
Compare
Yeah, not super happy about it, ideas (very) welcome how to make it cleaner!
Fixed now. There was also another issue that the new unit tests in testingfarm uncovered so yay for tests. |
achilleas-k
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit goes back to the approach we had in PR#565 to resolve using
the solver from outside of the container. The reason to back is that
some containers (like f41) do not have the python dnf available so
they break with the "run dnfjson inside" approach (that was meant
as a quick fix only anyway).
Huge kudos to Achilleas for most of the work here.
Closes: #700
It would be ideal if this could be tested end-to-end on a rhel9 system building a rhel9 iso installer.