Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Re-enable anaconda test #231

Closed
wants to merge 1 commit into from
Closed

test: Re-enable anaconda test #231

wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Contributor

@cgwalters cgwalters commented Mar 4, 2024 •
edited
Loading

Closes: #233

@cgwalters cgwalters mentioned this pull request Mar 5, 2024
Closed
@cgwalters cgwalters changed the title ci: Drop fedora:eln by default Pin eln to tag until ostree update is out in f39 Mar 6, 2024
@cgwalters

This comment was marked as resolved.

Sign in to view
mvo5
mvo5 previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cgwalters
Copy link
Contributor Author

Is bib (osbuild) not doing a "create temporary file, rename() into place on success" flow?

@mvo5
Copy link
Collaborator

mvo5 commented Mar 6, 2024

Is bib (osbuild) not doing a "create temporary file, rename() into place on success" flow?

I will look into this, it's definitely strange and something that needs investigating! Thanks for pointing it out.

@cgwalters
Copy link
Contributor Author

BTW @mvo5 feel free to push updates to this PR if you want

@mvo5

This comment was marked as resolved.

Sign in to view
@cgwalters
Copy link
Contributor Author

Yeah you may be right, agree it might just be that the output is hard to read and I got confused.

@mvo5 mvo5 changed the title Pin eln to tag until ostree update is out in f39 test: pin eln to tag until ostree update is out in f39 Mar 6, 2024
@mvo5

This comment was marked as resolved.

Sign in to view
@mvo5 mvo5 mentioned this pull request Mar 6, 2024
Merged
@cgwalters
Copy link
Contributor Author

@mvo5 and I chatted and I realized I just didn't go far enough back. I've updated this PR, let's see what the CI says.

@cgwalters
Copy link
Contributor Author

cgwalters commented Mar 6, 2024 •
edited
Loading

🎉

Tests / Integration (pull_request) Successful in 34m

That said, this can clearly wait a bit because we have a ton more to do on the ISO and in my opinion test coverage for it can lapse for a bit. I'll rebase at some point, but someone else can do so as well if they want.

@cgwalters cgwalters added the area/anaconda-iso Issues relating to the unattended Anaconda ISO label Mar 6, 2024
@cgwalters
Copy link
Contributor Author

OK I rebased 🏄 this one on main, and changed it to also explicitly re-enable the installer test.

@cgwalters cgwalters enabled auto-merge March 6, 2024 21:46
@cgwalters
Copy link
Contributor Author

https://bodhi.fedoraproject.org/updates/FEDORA-2024-969f546f80 is now queued for stable so...I'll update this PR sometime soon to just be lifting the skip on the ISO test.

@cgwalters cgwalters changed the title test: pin eln to tag until ostree update is out in f39 test: Re-enable anaconda test Mar 12, 2024
@cgwalters
Copy link
Contributor Author

OK now updated to just re-enable the test.

@cgwalters
tests: Re-enable the anaconda test
bde0213 
Now that the ostree update went stable.

Closes: osbuild#233
Signed-off-by: Colin Walters <[email protected]>
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Issue or PR with no activity for extended period of time label Apr 18, 2024
@mvo5
Copy link
Collaborator

mvo5 commented Apr 22, 2024

This is included in #379 where we also enable the centos iso test.

@github-actions github-actions bot removed the Stale Issue or PR with no activity for extended period of time label Apr 23, 2024
@ondrejbudai
Copy link
Member

This was already merged in #379. :)

auto-merge was automatically disabled April 30, 2024 10:02

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvo5 mvo5 mvo5 left review comments

Assignees
No one assigned
Labels
area/anaconda-iso Issues relating to the unattended Anaconda ISO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISO install fails to boot
3 participants
@cgwalters @mvo5 @ondrejbudai