Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: unbreak integration tests #146

Merged
merged 3 commits into from
Jan 23, 2024
Merged

many: unbreak integration tests #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52b6242
tmt: ask for bigger disks and get "df -h" output after testing
mvo5 Jan 22, 2024
673ce92
test: use last known goodl quay.io/centos-bootc/fedora-bootc in tests
mvo5 Jan 23, 2024
94b4ff7
test: add new `pytest.ini` and use `--basetemp=/var/tmp` by default
mvo5 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
pytest -rs -s -vv
pytest -rs -s -vv --basetemp="${TMPDIR}/tmp"
7 changes: 7 additions & 0 deletions plans/all.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ summary: Run all tests inside a VM environment
provision:
how: virtual
image: fedora:39
# 120 means 120GB, disk has to be specificed here, the format from:
# https://tmt.readthedocs.io/en/stable/spec/hardware.html#disk
# does not work here or below under "hardware"
disk: 120
hardware:
virtualization:
is-supported: true
Expand All @@ -17,3 +21,6 @@ prepare:
execute:
how: tmt
script: pytest -s -vv --force-aws-upload
finish:
how: shell
script: df -h
4 changes: 4 additions & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[pytest]
# do not use /tmp by default as it may be on a tempfs and our tests can
# generate 10G images (that full of holes so not really 10G but still)
addopts = --basetemp=/var/tmp
6 changes: 5 additions & 1 deletion test/containerbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@ def container_to_build_ref():
# making "image_type" an "image" tuple (type, container_ref_to_test)
return os.getenv(
"BIB_TEST_BOOTC_CONTAINER_TAG",
"quay.io/centos-bootc/fedora-bootc:eln",
# using this tag instead of ":eln" until
# https://github.com/CentOS/centos-bootc/issues/184 and
# https://github.com/osbuild/bootc-image-builder/issues/149
# are fixed
"quay.io/centos-bootc/fedora-bootc:ed19452a30c50900be0b78db5f68d9826cc14a2e402f752535716cffd92b4445",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we definitely need auto-rotating datestamped tags...

Copy link
Member

@achilleas-k achilleas-k Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get those, let's also have a regular auto-update job here so that changes in the base container are handled in isolated PRs.

)
Loading