Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backend/#139 #140

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Feature/backend/#139 #140

merged 3 commits into from
Oct 5, 2021

Conversation

134130
Copy link
Collaborator

@134130 134130 commented Oct 5, 2021

Many things were changed.

134130 added 3 commits October 5, 2021 14:38
@134130
Feat: Add filters for Algolia search
f6ba579 
Related to: #139
@134130
Fix: AlgoliaSearch result filtering
db9c9ac 
Algolia is searching from all items.
We need to restrict range for searching.

Restrict by Readable groups
Restrict searching Modified items.

Resolved: #139
@134130
Fix: JWT stores group
f7be416
@134130 134130 requested review from ntcho and phjppo0918 October 5, 2021 14:42
ntcho
ntcho approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@ntcho ntcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@134130 134130 linked an issue Oct 5, 2021 that may be closed by this pull request
Fix: AlgoliaSearch result filtering #139
Closed
2 tasks
@134130 134130 merged commit cfb7c43 into develop Oct 5, 2021
@134130 134130 deleted the feature/backend/#139 branch October 7, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phjppo0918 phjppo0918 phjppo0918 approved these changes

@ntcho ntcho ntcho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: AlgoliaSearch result filtering
3 participants
@134130 @ntcho @phjppo0918